ISLE: move icmp rewrites to separate file.#6120
Merged
cfallin merged 5 commits intoMar 31, 2023
Merged
Conversation
Move `icmp`-related rewrite rules from `algebraic.isle` to `icmp.isle`. Also move `icmp`-related tests from `algebraic.clif` to `icmp.clif`.
Member
|
Taking a look! |
cfallin
reviewed
Mar 30, 2023
jameysharp
reviewed
Mar 30, 2023
Member
|
@Kmeakin it looks like this is still not quite a verbatim move, which is making it tricky for me to verify -- e.g., this rule became I'm trying not to be too picky but I also find it much easier if code motion isn't mixed in with re-formatting, change of comments, etc.; if you don't mind, would you be able to redo the code-motion with a straight copy-paste, keeping things in the same order, then we can do other refactors later? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move
icmp-related rewrite rules fromalgebraic.isletoicmp.isle.Also move
icmp-related tests fromalgebraic.cliftoicmp.clif.