Skip to content

cargo-deny: allow the MPL-2.0 and OpenSSL licenses#6136

Merged
pchickey merged 2 commits into
mainfrom
pch/cargo_deny_add_licenses
Apr 3, 2023
Merged

cargo-deny: allow the MPL-2.0 and OpenSSL licenses#6136
pchickey merged 2 commits into
mainfrom
pch/cargo_deny_add_licenses

Conversation

@pchickey
Copy link
Copy Markdown
Contributor

@pchickey pchickey commented Apr 3, 2023

These are required in order to merge #5929.

I discussed this change with Till: we believe that these licenses are compatible with Wasmtime's license and don't add any fundamentally new requirements to the existing allow-list.

In an ideal world, I could imagine making an RFC or asking the Bytecode Alliance board weigh in on this decision, but we don't have any process or guidance for how to go about changing this list, and we don't expect this change to be controversial in any way. So, I've asked all of the BA TSC members (@fitzgen @tschneidereit @ricochet) to please approve this PR before I merge it.

These are required in order to merge #5929.
@pchickey pchickey requested a review from a team as a code owner April 3, 2023 17:23
@pchickey pchickey requested review from a team, elliottt, fitzgen and tschneidereit and removed request for a team and elliottt April 3, 2023 17:23
Comment thread deny.toml
"ISC",
"MIT",
"MPL-2.0",
"OpenSSL",
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is OpenSSL license still necessary if #5929 (comment) has switched to rustls?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, because the ring crate includes the OpenSSL license in its LICENSE file.

@ricochet
Copy link
Copy Markdown
Contributor

ricochet commented Apr 3, 2023

I am strongly in favor of adding MPL-2.0, but I needed to review OpenSSL. We may need to add an open source software acknowledgements section to the wasmtime docs to include "This product includes software developed by the OpenSSL Project
for use in the OpenSSL Toolkit. (http://www.openssl.org/)":

All advertising materials mentioning features or use of this
software must display the following acknowledgment:
"This product includes software developed by the OpenSSL Project
for use in the OpenSSL Toolkit. (http://www.openssl.org/)"
https://www.openssl.org/source/license-openssl-ssleay.txt

Copy link
Copy Markdown
Member

@tschneidereit tschneidereit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed, I agree with this change.

@ricochet, Pat and I talked about this and agreed that these licenses don't change anything foundational: we already have a few licenses that require attribution even for binary distributions, and need to figure out an approach to dealing with them. I have some thoughts on the topic, but given that these licenses don't fundamentally change the picture, I think all this doesn't need to hold up landing this change.

Copy link
Copy Markdown
Member

@fitzgen fitzgen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've always been partial to MPL-2.0 :)

@pchickey
Copy link
Copy Markdown
Contributor Author

pchickey commented Apr 3, 2023

I added 1 more commit that clarifies the license for ring.

@pchickey pchickey added this pull request to the merge queue Apr 3, 2023
Merged via the queue into main with commit 689f07c Apr 3, 2023
@pchickey pchickey deleted the pch/cargo_deny_add_licenses branch April 3, 2023 22:43
mbfm added a commit to eclipse-opendut/opendut that referenced this pull request Jan 27, 2026
`wasmtime` v39+ has an MPL-2.0 dependencies, so we avoid upgrading for now.

`wasmtime` also does not view the MPL-2.0 license as conflicting with
their Apache-2.0 license (somewhat contrary to our current understanding),
so we do not expect this to change in the near future:
bytecodealliance/wasmtime#6136
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants