wasmtime component bindgen: when tracing is enabled, emit an event for args & results#6209
Merged
Conversation
…r arguments and results This is consistient with what wiggle does (see https://github.com/bytecodealliance/wasmtime/blob/main/crates/wiggle/generate/src/funcs.rs#L266), with the exceptions that 1. wiggle has a facility for disabling tracing on a per-function basis, a requirement which was driven by functions which pass secrets into wasm. this will be added to wasmtime-wit-bindgen at a later date. 2. wiggle doesn't actually emit an event when calling a function which takes no arguments (see `&& func.params.len() > 0` in predicate), in this case we emit an event with the body `"call"`, to ensure these calls are observable.
pchickey
requested review from
alexcrichton and
elliottt
and removed request for
a team and
alexcrichton
alexcrichton
approved these changes
Apr 13, 2023
elliottt
approved these changes
Apr 13, 2023
Member
elliottt
left a comment
elliottt
left a comment
There was a problem hiding this comment.
Looks good to me! Just one suggestion about always including "call" in traces.
pchickey
pushed a commit
to bytecodealliance/preview2-prototyping
that referenced
this pull request
Apr 14, 2023
eduardomourar
pushed a commit
to eduardomourar/wasmtime
that referenced
this pull request
Apr 16, 2023
…r args & results (bytecodealliance#6209) * wasmtime component bindgen: when tracing is enabled, emit an event for arguments and results This is consistient with what wiggle does (see https://github.com/bytecodealliance/wasmtime/blob/main/crates/wiggle/generate/src/funcs.rs#L266), with the exceptions that 1. wiggle has a facility for disabling tracing on a per-function basis, a requirement which was driven by functions which pass secrets into wasm. this will be added to wasmtime-wit-bindgen at a later date. 2. wiggle doesn't actually emit an event when calling a function which takes no arguments (see `&& func.params.len() > 0` in predicate), in this case we emit an event with the body `"call"`, to ensure these calls are observable. * review feedback: add call and return messages to events * consistiency: dont drop `guest` from `wit-bindgen guest export` in span
pchickey
pushed a commit
to pchickey/wasmtime
that referenced
this pull request
May 16, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is consistient with what wiggle does (see
https://github.com/bytecodealliance/wasmtime/blob/main/crates/wiggle/generate/src/funcs.rs#L266), with the exceptions that
&& func.params.len() > 0in predicate), in this case we emit an event with the body"call", to ensure these calls are observable.