copy input msg into result of C API wasmtime_error_new#6369
Merged
alexcrichton merged 2 commits intoMay 11, 2023
Conversation
Subscribe to Label Actioncc @peterhuene DetailsThis issue or pull request has been labeled: "wasmtime:c-api"Thus the following users have been cc'd because of the following labels:
To subscribe or unsubscribe from this label, edit the |
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Contributor
Author
I tried looking at the details of the failed checks but was unable to find anything much to explain what happened. Is there anything I need to do to rectify this, or was it some sort of transient error and just needs to be added to the queue again? |
Member
|
Ah that's ok github actions was having a bad time yesterday so it's hopefully feeling better today |
salewski
pushed a commit
to salewski/wasmtime
that referenced
this pull request
Jun 30, 2023
…nce#6369) * copy input msg into result of C API wasmtime_error_new * make copy more clear with into_owned()
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix for issue discovered in #6359 for issue #6277. Input string was not copied into new
wasmtime_error_tresult.