Skip to content

Expose Config::static_memory_forced to C#6413

Merged
alexcrichton merged 2 commits into
bytecodealliance:mainfrom
angu26:expose-c-api-static_memory_forced
May 19, 2023
Merged

Expose Config::static_memory_forced to C#6413
alexcrichton merged 2 commits into
bytecodealliance:mainfrom
angu26:expose-c-api-static_memory_forced

Conversation

@angu26
Copy link
Copy Markdown
Contributor

@angu26 angu26 commented May 18, 2023

This change exposes the static_memory_forced configuration method to C. This matches other methods of the Config struct.

I don't believe an issue is needed here as this change is so small, but if you feel otherwise please let me know and I'd be happy to create an issue first 😄 .

@angu26 angu26 requested a review from a team as a code owner May 18, 2023 19:03
@angu26 angu26 requested review from pchickey and removed request for a team May 18, 2023 19:03
@angu26 angu26 changed the title Expose static_memory_forced to C Expose Config::static_memory_forced to C May 18, 2023
Copy link
Copy Markdown
Contributor

@pchickey pchickey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thank you!

@github-actions github-actions Bot added the wasmtime:c-api Issues pertaining to the C API. label May 18, 2023
@github-actions
Copy link
Copy Markdown

Subscribe to Label Action

cc @peterhuene

Details This issue or pull request has been labeled: "wasmtime:c-api"

Thus the following users have been cc'd because of the following labels:

  • peterhuene: wasmtime:c-api

To subscribe or unsubscribe from this label, edit the .github/subscribe-to-label.json configuration file.

Learn more.

@alexcrichton
Copy link
Copy Markdown
Member

Could you also update the config.h header file for this new option?

@angu26
Copy link
Copy Markdown
Contributor Author

angu26 commented May 18, 2023

Ah, sorry about that. I'll update that in just a moment.

(I accidentally updated it in my local copy of the wasmtime-cpp repo, rather than in the wasmtime source-of-truth 😓 )

@alexcrichton alexcrichton added this pull request to the merge queue May 19, 2023
Merged via the queue into bytecodealliance:main with commit e933c7e May 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

wasmtime:c-api Issues pertaining to the C API.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants