cranelift: Remove the fcvt_low_from_sint instruction#6565
Merged
alexcrichton merged 2 commits intoJun 13, 2023
Conversation
This commit removes this instruction since it's a combination of `swiden_low` plus `fcvt_from_sint`. This was used by the WebAssembly `f64x2.convert_low_i32x4_s` instruction previously but the corresponding unsigned variant of the instruction, `f64x2.convert_low_i32x4_u`, used a `uwiden_low` plus `fcvt_from_uint` combo. To help simplify Cranelift's instruction set and to make these two instructions mirrors of each other the Cranelift instruction is removed. The s390x and AArch64 backend lowering rules for this instruction could simply be deleted as the previous combination of the `swiden_low` and `fcvt_from_sint` lowering rules produces the same code. The x64 backend moved its lowering to a special case of the `fcvt_from_sint` lowering.
jameysharp
approved these changes
Jun 12, 2023
Contributor
jameysharp
left a comment
jameysharp
left a comment
There was a problem hiding this comment.
It's always nice to get rid of CLIF instructions and this one looks to have been remarkably painless. Thank you!
github-actions
Bot
added
cranelift
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
salewski
pushed a commit
to salewski/wasmtime
that referenced
this pull request
Jun 30, 2023
…nce#6565) * cranelift: Remove the `fcvt_low_from_sint` instruction This commit removes this instruction since it's a combination of `swiden_low` plus `fcvt_from_sint`. This was used by the WebAssembly `f64x2.convert_low_i32x4_s` instruction previously but the corresponding unsigned variant of the instruction, `f64x2.convert_low_i32x4_u`, used a `uwiden_low` plus `fcvt_from_uint` combo. To help simplify Cranelift's instruction set and to make these two instructions mirrors of each other the Cranelift instruction is removed. The s390x and AArch64 backend lowering rules for this instruction could simply be deleted as the previous combination of the `swiden_low` and `fcvt_from_sint` lowering rules produces the same code. The x64 backend moved its lowering to a special case of the `fcvt_from_sint` lowering. * Fix cranelift-fuzzgen build
salewski
pushed a commit
to salewski/wasmtime
that referenced
this pull request
Jun 30, 2023
…nce#6565) * cranelift: Remove the `fcvt_low_from_sint` instruction This commit removes this instruction since it's a combination of `swiden_low` plus `fcvt_from_sint`. This was used by the WebAssembly `f64x2.convert_low_i32x4_s` instruction previously but the corresponding unsigned variant of the instruction, `f64x2.convert_low_i32x4_u`, used a `uwiden_low` plus `fcvt_from_uint` combo. To help simplify Cranelift's instruction set and to make these two instructions mirrors of each other the Cranelift instruction is removed. The s390x and AArch64 backend lowering rules for this instruction could simply be deleted as the previous combination of the `swiden_low` and `fcvt_from_sint` lowering rules produces the same code. The x64 backend moved its lowering to a special case of the `fcvt_from_sint` lowering. * Fix cranelift-fuzzgen build
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit removes this instruction since it's a combination of
swiden_lowplusfcvt_from_sint. This was used by the WebAssemblyf64x2.convert_low_i32x4_sinstruction previously but the corresponding unsigned variant of the instruction,f64x2.convert_low_i32x4_u, used auwiden_lowplusfcvt_from_uintcombo. To help simplify Cranelift's instruction set and to make these two instructions mirrors of each other the Cranelift instruction is removed.The s390x and AArch64 backend lowering rules for this instruction could simply be deleted as the previous combination of the
swiden_lowandfcvt_from_sintlowering rules produces the same code. The x64 backend moved its lowering to a special case of thefcvt_from_sintlowering.