riscv64: Implement SIMD sqmul_round_sat and splat+mul instructions#6602
Merged
Conversation
afonso360
added
the
cranelift:area:riscv64
afonso360
changed the title
sqmul_round_sat and splat+imul instructionssqmul_round_sat and splat+mul instructions
github-actions
Bot
added
the
cranelift
elliottt
approved these changes
Jun 19, 2023
Member
elliottt
left a comment
elliottt
left a comment
There was a problem hiding this comment.
This looks good to me! The vx variants for some of the vector ops seem extremely useful!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
👋 Hey,
This PR Implements
sqmul_round_sat, we have a dedicated instruction for this so it's fairly straight forward.Additionally it also adds some variants of the existing multiplication instructions that splat one of the inputs. These were originally added before we had support for VX opcodes, and I've just noticed they were missing.