x64: Gate a lowering of pextrw on SSE4.1#6630
Merged
Merged
Conversation
The memory-store format of `pextrw` requires SSE4.1 despite `pextrw` itself only requiring SSE2. This commit updates this lowering to require an extra feature.
github-actions
Bot
added
cranelift
Contributor
|
I'm nominating @abrown to review this since Chris is on PTO this week. |
abrown
approved these changes
Jun 23, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The memory-store format of
pextrwrequires SSE4.1 despitepextrwitself only requiring SSE2. This commit updates this lowering to require an extra feature.