riscv64: Implement SIMD fcmp#6643
Merged
Merged
Conversation
afonso360
added
the
cranelift:area:riscv64
afonso360
force-pushed
the
riscv-simd-fcmp
branch
from
9a36006 to
21e36ec
Compare
github-actions
Bot
added
the
cranelift
alexcrichton
approved these changes
Jun 27, 2023
Member
alexcrichton
left a comment
alexcrichton
left a comment
There was a problem hiding this comment.
Nice! And thanks for the addition of all the exhaustive tests as always 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
👋 Hey,
This PR implements SIMD
fcmpfor RISC-V. This is a lot simpler thanicmpsince we don't have as many instructions to implement. Furthermore half of the rules are implemented with mask operations and other rules, so we save significant amounts of work by reusing the preexisting rules.All of these lowerings are based on what LLVM generates.