Cranelift: Leave the return address in place for most tail calls on x64 #6650
Merged
fitzgen merged 1 commit intoJun 27, 2023
Conversation
github-actions
Bot
added
cranelift
Subscribe to Label ActionDetailsThis issue or pull request has been labeled: "cranelift", "cranelift:area:aarch64", "cranelift:area:machinst", "cranelift:area:x64", "isle"Thus the following users have been cc'd because of the following labels:
To subscribe or unsubscribe from this label, edit the |
When the size of the tail callee's and tail caller's stack arguments is the same, we don't need to copy the return address and then write it to the stack again, since its original location will also be its final location. That is, we were previously reading a value and then writing it back to the exact same location.
fitzgen
force-pushed
the
leave-return-address-in-place-for-most-tail-calls
branch
from
1a77ae7 to
58b2f6b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the size of the tail callee's and tail caller's stack arguments is the same, we don't need to copy the return address and then write it to the stack again, since its original location will also be its final location. That is, we were previously reading a value and then writing it back to the exact same location.
Builds on top of #6635