preview2: refactor WasiCtxBuilder impl, and make WasiCtx fields private#6652
Merged
Conversation
The optional-fields WasiCtxBuilder was an intermediate stepping stone which has outlived its usefulness - there is now only one sensible default value for each field, so we no longer need to expose the Default (empty) constructor. There is no need for the WasiCtx::builder method being an alias for default, and it creates user confusion. Finally, the WasiCtx itself is a private implementation detail for use in this crate only. The WasiCtxBuilder is the only way to customize its contents. We don't want to let users modify the fields of WasiCtx after it has been used by a wasm guest, because the guest may have made assumptions that fields won't change - e.g. the stderr field is fetched once by the adapter and assumed to always be the same, environment variables are copied into libc once and assumed to always be the same.
pchickey
requested review from
alexcrichton and
itsrainy
and removed request for
a team and
itsrainy
alexcrichton
approved these changes
Jun 27, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The optional-fields WasiCtxBuilder was an intermediate stepping stone which has outlived its usefulness - there is now only one sensible default value for each field, so we no longer need to expose the Default (empty) constructor.
There is no need for the WasiCtx::builder method being an alias for default, and it creates user confusion.
Finally, the WasiCtx itself is a private implementation detail for use in this crate only. The WasiCtxBuilder is the only way to customize its contents. We don't want to let users modify the fields of WasiCtx after it has been used by a wasm guest, because the guest may have made assumptions that fields won't change - e.g. the stderr field is fetched once by the adapter and assumed to always be the same, environment variables are copied into libc once and assumed to always be the same.