riscv64: Implement various SIMD float ops#6657
Merged
alexcrichton merged 4 commits intoJun 28, 2023
Merged
Conversation
afonso360
added
the
cranelift:area:riscv64
github-actions
Bot
added
the
cranelift
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
👋 Hey,
This PR implements a few SIMD float ops. These are:
fabsfcopysignfmin_pseudofmax_pseudofminfmaxf{min,max}are slightly complicated since we don't have a instruction that exactly matches the required semantics. The implementation here builds a mask for the inputs that are NaN and returns the canonical NaN in these cases. This is the same lowering that V8 uses.I've had to alter the
simd-fmax-fmintests since they were expecting the sign bit of the resulting NaN to be unchanged, however this seems not to be required as per our documentation. I've moved these tests to thenondeterministictestsuites that we have.