Implement the tcp interface of wasi-sockets.#6837
Merged
sunfishcode merged 16 commits intoAug 23, 2023
Merged
Conversation
sunfishcode
force-pushed
the
sunfishcode/sockets
branch
6 times, most recently
from
01a3660 to
a1879d4
Compare
pchickey
approved these changes
Aug 16, 2023
Contributor
pchickey
left a comment
pchickey
left a comment
There was a problem hiding this comment.
This is excellent, I am very excited to see this land!
sunfishcode
force-pushed
the
sunfishcode/sockets
branch
from
fccfdb0 to
37b0521
Compare
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
Bot
removed this pull request from the merge queue due to a conflict with the base branch
sunfishcode
force-pushed
the
sunfishcode/sockets
branch
from
cdb45d2 to
9d10440
Compare
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
sunfishcode
force-pushed
the
sunfishcode/sockets
branch
7 times, most recently
from
f8bde95 to
8b049ef
Compare
Implement the `tcp`, `tcp-create-socket`, and `network` interfaces of wasi-sockets.
This requires an updated tokio for `Interest::ERROR`.
sunfishcode
force-pushed
the
sunfishcode/sockets
branch
from
8b049ef to
ebe48ca
Compare
pchickey
approved these changes
Aug 22, 2023
eduardomourar
pushed a commit
to eduardomourar/wasmtime
that referenced
this pull request
Sep 6, 2023
* Implement the `tcp` interface of wasi-sockets. Implement the `tcp`, `tcp-create-socket`, and `network` interfaces of wasi-sockets. * Minor cleanups. * Update to the latest upstream wasi-sockets. * Address review feedback. * Handle zero-length reads and writes, and other cleanups. * Fix compilation on macOS. * Fix compilation on Windows. * Update all the copies of wasi-socket wit files. * Sync up more wit files. * Fix the errno code for non-blocking `connect` on Windows. prtest:full * Tolerate `NOTCONN` errors when cleaning up with `shutdown`. * Simplify the polling mechanism. This requires an updated tokio for `Interest::ERROR`. * Downgrade to tokio 1.29.1 for now. * Move `tcp_state` out of the `Arc`. * `accept` doesn't need a write lock. * Remove `tcp_state`'s `RwLock`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implement the
tcp,tcp-create-socket, andnetworkinterfaces of wasi-sockets.The test doesn't pass yet, because I haven't figured out how to get it to build and run properly yet.