Fix character boundary issues in preview1 host adapter#7011
Merged
pchickey merged 2 commits intoSep 20, 2023
Conversation
This fixes two separate issues in the preview1-to-preview2 host-side adapter in the `wasmtime-wasi` crate. Both instances were copying a truncated string to the guest program but the truncation was happening in the middle of a unicode character so truncation now happens on bytes instead of a string.
Try to weed out any accidental string-related issues for the future.
pchickey
approved these changes
Sep 20, 2023
eduardomourar
pushed a commit
to eduardomourar/wasmtime
that referenced
this pull request
Sep 22, 2023
…nce#7011) * Fix character boundary issues in preview1 host adapter This fixes two separate issues in the preview1-to-preview2 host-side adapter in the `wasmtime-wasi` crate. Both instances were copying a truncated string to the guest program but the truncation was happening in the middle of a unicode character so truncation now happens on bytes instead of a string. * Update `write_bytes` to take `&[u8]` Try to weed out any accidental string-related issues for the future.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes two separate issues in the preview1-to-preview2 host-side adapter in the
wasmtime-wasicrate. Both instances were copying a truncated string to the guest program but the truncation was happening in the middle of a unicode character so truncation now happens on bytes instead of a string.Closes #7006