Skip to content

impl Clone for wasmtime::component::Linker#7032

Merged
alexcrichton merged 1 commit into
bytecodealliance:mainfrom
acfoltzer:component-linker-impl-clone
Sep 14, 2023
Merged

impl Clone for wasmtime::component::Linker#7032
alexcrichton merged 1 commit into
bytecodealliance:mainfrom
acfoltzer:component-linker-impl-clone

Conversation

@acfoltzer
Copy link
Copy Markdown
Contributor

The core Wasm Linker type is clonable, and the component linker needs to be used in similar settings where clonability is important.

@acfoltzer acfoltzer requested a review from a team as a code owner September 14, 2023 00:47
@acfoltzer acfoltzer self-assigned this Sep 14, 2023
@acfoltzer acfoltzer requested review from fitzgen and removed request for a team September 14, 2023 00:47
@acfoltzer acfoltzer marked this pull request as draft September 14, 2023 00:49
@acfoltzer
Copy link
Copy Markdown
Contributor Author

D'oh, I immediately realized why there's a custom impl for the other Linker...

The core Wasm `Linker` type is clone, and the component linker needs to be used in similar settings
where clonability is important.
@acfoltzer acfoltzer force-pushed the component-linker-impl-clone branch from 83bbfb7 to d834769 Compare September 14, 2023 00:52
@acfoltzer acfoltzer marked this pull request as ready for review September 14, 2023 00:53
@github-actions github-actions Bot added the wasmtime:api Related to the API of the `wasmtime` crate itself label Sep 14, 2023
@github-actions
Copy link
Copy Markdown

Subscribe to Label Action

cc @peterhuene

Details This issue or pull request has been labeled: "wasmtime:api"

Thus the following users have been cc'd because of the following labels:

  • peterhuene: wasmtime:api

To subscribe or unsubscribe from this label, edit the .github/subscribe-to-label.json configuration file.

Learn more.

@alexcrichton alexcrichton added this pull request to the merge queue Sep 14, 2023
@alexcrichton
Copy link
Copy Markdown
Member

Thanks!

Merged via the queue into bytecodealliance:main with commit c4f261a Sep 14, 2023
eduardomourar pushed a commit to eduardomourar/wasmtime that referenced this pull request Sep 15, 2023
The core Wasm `Linker` type is clone, and the component linker needs to be used in similar settings
where clonability is important.
eduardomourar pushed a commit to eduardomourar/wasmtime that referenced this pull request Sep 22, 2023
The core Wasm `Linker` type is clone, and the component linker needs to be used in similar settings
where clonability is important.
@acfoltzer acfoltzer deleted the component-linker-impl-clone branch September 25, 2023 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

wasmtime:api Related to the API of the `wasmtime` crate itself

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants