Skip to content

c-api: expose memory_init_cow#7227

Merged
fitzgen merged 2 commits into
bytecodealliance:mainfrom
rockwotj:cow
Oct 12, 2023
Merged

c-api: expose memory_init_cow#7227
fitzgen merged 2 commits into
bytecodealliance:mainfrom
rockwotj:cow

Conversation

@rockwotj
Copy link
Copy Markdown
Contributor

@rockwotj rockwotj commented Oct 12, 2023

The main motivation for exposing this is if you're using a custom host allocator then you can't use these, so you might as well not generate them in the first place.

@rockwotj rockwotj requested a review from a team as a code owner October 12, 2023 16:44
@rockwotj rockwotj requested review from pchickey and removed request for a team October 12, 2023 16:44
Signed-off-by: Tyler Rockwood <rockwood@redpanda.com>
I really wish these were autogenerated :/

Signed-off-by: Tyler Rockwood <rockwood@redpanda.com>
@github-actions github-actions Bot added the wasmtime:c-api Issues pertaining to the C API. label Oct 12, 2023
@github-actions
Copy link
Copy Markdown

Subscribe to Label Action

cc @peterhuene

Details This issue or pull request has been labeled: "wasmtime:c-api"

Thus the following users have been cc'd because of the following labels:

  • peterhuene: wasmtime:c-api

To subscribe or unsubscribe from this label, edit the .github/subscribe-to-label.json configuration file.

Learn more.

Copy link
Copy Markdown
Member

@fitzgen fitzgen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@fitzgen fitzgen added this pull request to the merge queue Oct 12, 2023
Merged via the queue into bytecodealliance:main with commit f534373 Oct 12, 2023
@rockwotj rockwotj deleted the cow branch October 13, 2023 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

wasmtime:c-api Issues pertaining to the C API.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants