Preserve uext and sext flags for parameters on x86_64 and apple aarch64#7325
Merged
alexcrichton merged 1 commit intoOct 23, 2023
Merged
Conversation
This is required by the ABI and prevents a miscompilation when calling LLVM compiled functions.
bjorn3
force-pushed
the
fix_x86_uext_sext_args
branch
from
d295399 to
06e308e
Compare
Contributor
Author
|
Moved it from a precise-output test to a regular compile test as precise-output doesn't allow any comments. |
github-actions
Bot
added
cranelift
Contributor
Author
|
If possible a patch release with this would be nice. It is the last known miscompilation in cg_clif and IMO a blocker for rust-lang/rust#81746. |
alexcrichton
approved these changes
Oct 23, 2023
Member
alexcrichton
left a comment
alexcrichton
left a comment
There was a problem hiding this comment.
Thanks! And yeah I think a point release is ok for this. Would you be ok doing the backport?
Contributor
Author
|
Sure |
Contributor
Author
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Contributor
Author
|
Spurious network error? |
Member
|
Yeah downloading doxygen is occasionally flaky and weird. I requeued this and it should merge in the next few minutes |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is required by the ABI and prevents a miscompilation when calling LLVM compiled functions.
Fixes #7210
Fixes https://github.com/bjorn3/rustc_codegen_cranelift/issues/1395