Skip to content

[14.0.2] Allow disabling the host-arch feature of cranelift-codegen#7371

Merged
alexcrichton merged 1 commit into
bytecodealliance:release-14.0.0from
bjorn3:backport_allow_disabling_host_arch
Oct 25, 2023
Merged

[14.0.2] Allow disabling the host-arch feature of cranelift-codegen#7371
alexcrichton merged 1 commit into
bytecodealliance:release-14.0.0from
bjorn3:backport_allow_disabling_host_arch

Conversation

@bjorn3
Copy link
Copy Markdown
Contributor

@bjorn3 bjorn3 commented Oct 25, 2023

This is required to compile for a target which doesn't have a cranelift
backend. Before this change using any of the cranelift crates that
depend on cranelift-codegen would forcefully enable all default features
and thus host-arch. With this change only the std and unwind features
are still forcefully enabled as cranelift-codegen doesn't compile with
either disabled.

Backport of #7369

This is required to compile for a target which doesn't have a cranelift
backend. Before this change using any of the cranelift crates that
depend on cranelift-codegen would forcefully enable all default features
and thus host-arch. With this change only the std and unwind features
are still forcefully enabled as cranelift-codegen doesn't compile with
either disabled.
@bjorn3 bjorn3 requested review from a team as code owners October 25, 2023 19:40
@bjorn3 bjorn3 requested review from pchickey and removed request for a team October 25, 2023 19:40
@alexcrichton alexcrichton removed the request for review from pchickey October 25, 2023 19:43
@alexcrichton alexcrichton merged commit f6f9f36 into bytecodealliance:release-14.0.0 Oct 25, 2023
@bjorn3 bjorn3 deleted the backport_allow_disabling_host_arch branch October 25, 2023 21:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants