Enable copy-on-write memories for components#7459
Merged
Merged
Conversation
This commit fixes a mistake in component compilation where copy-on-write and lazy initialization of function tables was accidentally not performed. I believe this is an accidental regression from a previous refactor, and this commit now ensures that the shared infrastructure between components and core modules accounts for copy-on-write and lazy table initialization.
github-actions
Bot
added
the
wasmtime:api
Subscribe to Label Actioncc @peterhuene DetailsThis issue or pull request has been labeled: "wasmtime:api"Thus the following users have been cc'd because of the following labels:
To subscribe or unsubscribe from this label, edit the |
fitzgen
approved these changes
Nov 3, 2023
Member
fitzgen
left a comment
fitzgen
left a comment
There was a problem hiding this comment.
Any way we can write a regression test here?
Member
Author
|
Sure! |
elliottt
pushed a commit
to elliottt/wasmtime
that referenced
this pull request
Nov 3, 2023
* Enable copy-on-write memories for components This commit fixes a mistake in component compilation where copy-on-write and lazy initialization of function tables was accidentally not performed. I believe this is an accidental regression from a previous refactor, and this commit now ensures that the shared infrastructure between components and core modules accounts for copy-on-write and lazy table initialization. * Add some tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit fixes a mistake in component compilation where copy-on-write and lazy initialization of function tables was accidentally not performed. I believe this is an accidental regression from a previous refactor, and this commit now ensures that the shared infrastructure between components and core modules accounts for copy-on-write and lazy table initialization.