c-api: support yielding in wasmtime_store_epoch_deadline_callback#7476
Merged
Conversation
alexcrichton
approved these changes
Nov 3, 2023
Signed-off-by: Tyler Rockwood <rockwood@redpanda.com>
Contributor
Author
|
Fixed |
Contributor
Author
|
Force push: Fixed linter warning for dead code and moved the CallbackDataPtr struct now that it's not used in |
Signed-off-by: Tyler Rockwood <rockwood@redpanda.com>
Contributor
Author
|
Force push: Fix typedef (it's not a C++ using def...) |
Subscribe to Label Actioncc @peterhuene DetailsThis issue or pull request has been labeled: "wasmtime:c-api"Thus the following users have been cc'd because of the following labels:
To subscribe or unsubscribe from this label, edit the |
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
prtest:full
Signed-off-by: Tyler Rockwood <rockwood@redpanda.com>
Signed-off-by: Tyler Rockwood <rockwood@redpanda.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow supporting yielding in the epoch callback in addition to continuing, additionally support a finalizer, as that is the "standard" approach to the C API. Happy to take suggestion on API alternatives.