Run custom signal handler tests on macOS#7509
Merged
fitzgen merged 1 commit intoNov 8, 2023
Merged
Conversation
This commit fixes a mistake where these tests were not being run on macOS after signal handling was moved behind a `Config` flag instead of being a crate feature. Additionally these tests are moved to their own test file to ensure that each process either uses Mach Ports or signals (this one uses signals which is non-default).
fitzgen
approved these changes
Nov 8, 2023
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit fixes a mistake where these tests were not being run on macOS after signal handling was moved behind a
Configflag instead of being a crate feature. Additionally these tests are moved to their own test file to ensure that each process either uses Mach Ports or signals (this one uses signals which is non-default).