feat: implement ResourceAny -> Resource<T> conversion#7712
Merged
alexcrichton merged 1 commit intoJan 4, 2024
Merged
Conversation
Member
Author
github-actions
Bot
added
the
wasmtime:api
Subscribe to Label Actioncc @peterhuene DetailsThis issue or pull request has been labeled: "wasmtime:api"Thus the following users have been cc'd because of the following labels:
To subscribe or unsubscribe from this label, edit the |
rvolosatovs
force-pushed
the
feat/resource-any-2-resource
branch
3 times, most recently
from
accf39c to
00ca470
Compare
github-actions
Bot
added
the
cranelift
alexcrichton
reviewed
Jan 2, 2024
Member
alexcrichton
left a comment
alexcrichton
left a comment
There was a problem hiding this comment.
Looks reasonable to me, thanks!
There's one minor API-design question where it's not possible to recover from this method if it fails due to consumption of the ResourceAny input. That being said the main failure condition, the wrong type, can be tested manually ahead of time, so I think that's ok.
Signed-off-by: Roman Volosatovs <rvolosatovs@riseup.net>
rvolosatovs
force-pushed
the
feat/resource-any-2-resource
branch
from
00ca470 to
6b72f00
Compare
rvolosatovs
requested review from
alexcrichton and
pchickey
and removed request for
a team
alexcrichton
approved these changes
Jan 4, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #7704
Follow-up on #7688 (based on that PR for simplicity)
Once #7688 is merged, I'll rebase such that only 5b20daf would be in this PR. Also happy to move the commit to #7688 if you prefer