Fix ty_half_width in isle prelude#7715
Merged
Merged
Conversation
fitzgen
approved these changes
Dec 21, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I spent way too long trying to figure out how I'd gotten a rule wrong, only to find out that
ty_half_widthin ISLE was doing something different fromType::half_widthin the rest of the codebase.Thus this PR, which stops it having a custom implementation in ISLE and just calls the normal method. I think anywhere in ISLE rules that wants to exclude the other cases should be using
fits_in_64or similar, not having thety_half_widthextern do something surprising.The existing uses
wasmtime/cranelift/codegen/src/isa/riscv64/lower.isle
Lines 115 to 123 in 37300d3
are under
ty_vec_fits_in_registeralready, so it's fine.