winch: Add memory instructions#7721
Merged
saulecabrera merged 2 commits intoJan 3, 2024
Merged
Conversation
saulecabrera
requested review from
abrown,
alexcrichton and
fitzgen
and removed request for
a team and
abrown
github-actions
Bot
added
fuzzing
Subscribe to Label ActionDetailsThis issue or pull request has been labeled: "fuzzing", "winch"Thus the following users have been cc'd because of the following labels:
To subscribe or unsubscribe from this label, edit the |
This commit adds support for the following memory instructions to winch: * `data.drop` * `memory.init` * `memory.fill` * `memory.copy` * `memory.size` * `memory.grow` In general the implementation is similar to what other instructions via builtins are hanlded (e.g. table instructions), which involve stack manipulation prior to emitting a builtin function call, with the exception of `memory.size`, which involves loading the current length from the `VMContext`
saulecabrera
force-pushed
the
winch-memory-instructions
branch
from
4dfe911 to
a1b119f
Compare
alexcrichton
approved these changes
Jan 2, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit adds support for the following memory instructions to winch:
data.dropmemory.initmemory.fillmemory.copymemory.sizememory.growIn general the implementation is similar to what other instructions via builtins are handled (e.g. table instructions), which involve stack manipulation prior to emitting a builtin function call, with the exception of
memory.size, which involves loading the current length from theVMContextpointer.