Switch winch's internal stack from a VecDeque to a Vec#7756
Merged
saulecabrera merged 1 commit intoJan 5, 2024
Conversation
It doesn't look like which needs to modify the front of the `VecDeque` that it uses to model the value stack, and can instead use a `Vec`.
elliottt
requested review from
abrown and
saulecabrera
and removed request for
a team
saulecabrera
approved these changes
Jan 5, 2024
Member
saulecabrera
left a comment
saulecabrera
left a comment
There was a problem hiding this comment.
This looks reasonable to me, thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It doesn't look like which needs to modify the front of the
VecDequethat it uses to model the value stack, and can instead use aVec. This shouldn't change functionality at all, but seems nice for documentation purposes, as I initially assumed that there must be operations modifying the front of the stack given the use ofVecDeque.