demange names in guest-profiler output

[high-cloud]

issue #7665

[github-actions]

Subscribe to Label Action

cc @peterhuene

Details

This issue or pull request has been labeled: "wasmtime:api"

Thus the following users have been cc'd because of the following labels:

• peterhuene: wasmtime:api

To subscribe or unsubscribe from this label, edit the .github/subscribe-to-label.json configuration file.

Learn more.

[jameysharp]

This is great, thank you!

I hesitated about the use of unwrap, but demangle_function_name can only fail if the writer fails, and I don't think the Write implementation for String can fail, so I'll sign off that this use is fine. We have another unwrap on the use of this function in CompiledModule::register_debug_and_profiling, anyway.

While looking at that, I just noticed that there's a demangle_function_name_or_index function which is very similar to what this whole match statement does. I think it's harmless to duplicate that here, with a slightly different format for the fallback case when there's no function name.

I'm going to merge this as-is. But if you want to open a follow-up PR, I think it would be an improvement to use demangle_function_name_or_index here.