Skip to content

Add C API for GuestProfiler#7854

Merged
alexcrichton merged 7 commits into
bytecodealliance:mainfrom
Milek7:guestprofiler-c-api
Feb 5, 2024
Merged

Add C API for GuestProfiler#7854
alexcrichton merged 7 commits into
bytecodealliance:mainfrom
Milek7:guestprofiler-c-api

Conversation

@Milek7
Copy link
Copy Markdown
Contributor

@Milek7 Milek7 commented Feb 1, 2024

No description provided.

@Milek7 Milek7 requested a review from a team as a code owner February 1, 2024 03:32
@Milek7 Milek7 requested review from alexcrichton and removed request for a team February 1, 2024 03:32
@Milek7
Copy link
Copy Markdown
Contributor Author

Milek7 commented Feb 1, 2024

Sorry for the noise with #7853, I messed up with Git.

@github-actions github-actions Bot added the wasmtime:c-api Issues pertaining to the C API. label Feb 1, 2024
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Feb 1, 2024

Subscribe to Label Action

cc @peterhuene

Details This issue or pull request has been labeled: "wasmtime:c-api"

Thus the following users have been cc'd because of the following labels:

  • peterhuene: wasmtime:c-api

To subscribe or unsubscribe from this label, edit the .github/subscribe-to-label.json configuration file.

Learn more.

Copy link
Copy Markdown
Member

@alexcrichton alexcrichton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR here, and looks good to me! I've got some small suggestions here and there but let me know if I can clarify or help out.

Comment thread crates/c-api/include/wasmtime/profiling.h
Comment thread crates/c-api/include/wasmtime/profiling.h Outdated
Comment thread crates/c-api/src/profiling.rs Outdated
Comment thread crates/c-api/include/wasmtime/profiling.h
@Milek7
Copy link
Copy Markdown
Contributor Author

Milek7 commented Feb 2, 2024

I think I addressed everything for now.

@Milek7 Milek7 requested a review from alexcrichton February 3, 2024 21:58
Copy link
Copy Markdown
Member

@alexcrichton alexcrichton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this!

@alexcrichton alexcrichton added this pull request to the merge queue Feb 5, 2024
@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Feb 5, 2024
@Milek7 Milek7 requested a review from alexcrichton February 5, 2024 17:31
@alexcrichton alexcrichton added this pull request to the merge queue Feb 5, 2024
Merged via the queue into bytecodealliance:main with commit d4eaacd Feb 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

wasmtime:c-api Issues pertaining to the C API.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants