winch: Ensure correct handling of libcalls#7949
Merged
saulecabrera merged 1 commit intoFeb 16, 2024
Merged
Conversation
Member
Author
|
I'm unsure if there's an additional way to test this one aside from the filetests. |
github-actions
Bot
added
cranelift
Subscribe to Label ActionDetailsThis issue or pull request has been labeled: "cranelift", "winch"Thus the following users have been cc'd because of the following labels:
To subscribe or unsubscribe from this label, edit the |
This commit fixes a fuzz bug where modules involving known libcalls would fail to compile given that they were unconditionally treated as colocated libcalls. This bug is only reproducible in non sse41 environments, given that some operations like `floor` default to libcalls in this case. The `use_colocated_libcalls` setting is not configurable within Wasmtime and as such, they should be loaded into a register prior to emitting the call. This will also ensure that the right 8-byte absolute relocation is used.
saulecabrera
force-pushed
the
fix-fuzz-bug-libcalls
branch
from
a431814 to
4fa2d3b
Compare
elliottt
approved these changes
Feb 16, 2024
Member
elliottt
left a comment
elliottt
left a comment
There was a problem hiding this comment.
This looks good to me! As far as testing goes, this was caught by fuzzing so I think we're good. We could always look into running some of the spec tests with different codegen configurations, but that probably still won't catch as much as fuzzing will.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit fixes a fuzz bug where modules involving known libcalls would fail to compile given that they were unconditionally treated as colocated libcalls.
This bug is only reproducible in non sse41 environments, given that some operations like
floordefault to libcalls in this case. Theuse_colocated_libcallssetting is not configurable within Wasmtime and as such, they should be loaded into a register prior to emitting the call. This will also ensure that the right 8-byte absolute relocation is used.