Wasmtime: Add a gc cargo feature#7975
Conversation
|
I didn't add a smoke test build without the |
Subscribe to Label Actioncc @peterhuene DetailsThis issue or pull request has been labeled: "wasmtime:api", "wasmtime:config"Thus the following users have been cc'd because of the following labels:
To subscribe or unsubscribe from this label, edit the |
Label Messager: wasmtime:configIt looks like you are changing Wasmtime's configuration options. Make sure to
DetailsTo modify this label's message, edit the To add new label messages or remove existing label messages, edit the |
alexcrichton
left a comment
There was a problem hiding this comment.
Nice!
My main comments below are about perhaps shifting around #[cfg] to try to reduce it. That's my main worried with these sorts of features is that it can become difficult in the limit to ensure all the #[cfg] annotations are aligned so I'm hoping we can try to reduce them as much as possible. More-or-less I think that ExternRef and probably VMExternRef should have the same API no matter the feature set (modulo constructors) and that way consumers don't have to #[cfg] which should help centralize this.
We'll also definitely want this on CI and I'd recommend putting it around here
|
Okay, I've updated this PR to stub out more |
9e6ee16 to
62555ad
Compare
Subscribe to Label ActionDetailsThis issue or pull request has been labeled: "wasmtime:ref-types", "winch"Thus the following users have been cc'd because of the following labels:
To subscribe or unsubscribe from this label, edit the |
Subscribe to Label Actioncc @peterhuene DetailsThis issue or pull request has been labeled: "wasmtime:c-api"Thus the following users have been cc'd because of the following labels:
To subscribe or unsubscribe from this label, edit the |
e36c641 to
48fe5e1
Compare
This controls whether support for `ExternRef` and its associated deferred, reference-counting garbage collector is enabled at compile time or not. It will also be used for similarly for Wasmtime's full Wasm GC support as that gets added.
…mentation of `[VM]ExternRef`
8134e78 to
21061df
Compare
This controls whether support for
ExternRefand its associated deferred, reference-counting garbage collector is enabled at compile time or not. It will also be used for similarly for Wasmtime's full Wasm GC support as that gets added.