Don't infer host flags for cross-compiled targets#7991
Merged
fitzgen merged 1 commit intoFeb 23, 2024
Conversation
This commit fixes an accidental regression from bytecodealliance#7766 where `infer_native_flags` is called even if a target is explicitly specified to a `Config`. Now inference only happens if a target isn't specified meaning that the host is selected.
fitzgen
approved these changes
Feb 23, 2024
saulecabrera
pushed a commit
to saulecabrera/wasmtime
that referenced
this pull request
Mar 12, 2024
) This commit fixes an accidental regression from bytecodealliance#7766 where `infer_native_flags` is called even if a target is explicitly specified to a `Config`. Now inference only happens if a target isn't specified meaning that the host is selected.
saulecabrera
pushed a commit
to saulecabrera/wasmtime
that referenced
this pull request
Mar 12, 2024
) This commit fixes an accidental regression from bytecodealliance#7766 where `infer_native_flags` is called even if a target is explicitly specified to a `Config`. Now inference only happens if a target isn't specified meaning that the host is selected.
saulecabrera
added a commit
that referenced
this pull request
Mar 12, 2024
This commit fixes an accidental regression from #7766 where `infer_native_flags` is called even if a target is explicitly specified to a `Config`. Now inference only happens if a target isn't specified meaning that the host is selected. Co-authored-by: Alex Crichton <alex@alexcrichton.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit fixes an accidental regression from #7766 where
infer_native_flagsis called even if a target is explicitly specified to aConfig. Now inference only happens if a target isn't specified meaning that the host is selected.