winch: Switch to using cranelift for all trampolines#8109
Merged
elliottt merged 3 commits intoMar 21, 2024
Conversation
elliottt
force-pushed
the
trevor/winch-remove-trampolines
branch
from
e8412a7 to
c2d6f3e
Compare
Subscribe to Label ActionDetailsThis issue or pull request has been labeled: "winch"Thus the following users have been cc'd because of the following labels:
To subscribe or unsubscribe from this label, edit the |
elliottt
force-pushed
the
trevor/winch-remove-trampolines
branch
from
c2d6f3e to
b5162c3
Compare
elliottt
requested review from
alexcrichton and
cfallin
and removed request for
a team
elliottt
commented
Mar 13, 2024
saulecabrera
approved these changes
Mar 14, 2024
Member
saulecabrera
left a comment
saulecabrera
left a comment
There was a problem hiding this comment.
LGTM, thanks!
One thing that I wanted to note: Winch is still missing support for emit_trampolines_for_array_call_host_func, would it make sense to implement that function in this PR? I think a follow-up also works!
elliottt
force-pushed
the
trevor/winch-remove-trampolines
branch
2 times, most recently
from
d25b23b to
30e21ba
Compare
github-actions
Bot
added
cranelift
elliottt
force-pushed
the
trevor/winch-remove-trampolines
branch
5 times, most recently
from
f0f5a9a to
f566a6a
Compare
elliottt
force-pushed
the
trevor/winch-remove-trampolines
branch
from
f566a6a to
e56d30d
Compare
elliottt
force-pushed
the
trevor/winch-remove-trampolines
branch
from
c47c87b to
41abec2
Compare
alexcrichton
pushed a commit
to alexcrichton/wasmtime
that referenced
this pull request
Mar 21, 2024
…e#8109) * Return the last result through registers in the winch calling convention * Switch winch over to using cranelift for all trampolines * Fix unused code warnings
prtest:full
elliottt
force-pushed
the
trevor/winch-remove-trampolines
branch
from
41abec2 to
55c47ff
Compare
alexcrichton
pushed a commit
to alexcrichton/wasmtime
that referenced
this pull request
Mar 21, 2024
…e#8109) * Return the last result through registers in the winch calling convention * Switch winch over to using cranelift for all trampolines * Fix unused code warnings
saulecabrera
added a commit
to saulecabrera/wasmtime
that referenced
this pull request
Jul 19, 2024
This register was used as an additional scratch register in the context of trampolines. As of bytecodealliance#8109, trampolines are implemented with Cranelift, so this register alias is unused.
github-merge-queue Bot
pushed a commit
that referenced
this pull request
Jul 19, 2024
This register was used as an additional scratch register in the context of trampolines. As of #8109, trampolines are implemented with Cranelift, so this register alias is unused.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove the winch MacroAssembler-based trampolines, and reuse the trampoline-generation from the
wasmtime-cranliftcrate instead.Fixes #8098