Remove some more cranelift-filetest wasm testing bits#8143
Merged
alexcrichton merged 5 commits intoMar 15, 2024
Conversation
No longer needed with tests having moved out to `tests/disas`
No need for `test_wasm.rs` to stick around in cranelift-filetest, so move the bits up a layer.
alexcrichton
requested review from
cfallin and
fitzgen
and removed request for
a team
github-actions
Bot
added
the
cranelift
cfallin
approved these changes
Mar 15, 2024
bjorn3
reviewed
Mar 15, 2024
alexcrichton
force-pushed
the
remove-some-more-test-bits
branch
from
455c0ec to
d6976a6
Compare
Member
Author
|
This hit an unusual error on CI which looked like: Apparently the removal of the wasm-related dependencies also removed all dependencies on libm for riscv64 which meant that tests were failing as a dlsym for various libcall symbols was failing. I just added a commit which forces linking to libm by referring to a symbol and calling it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some more cleanup enabled through #8140 and #8129