Skip to content

Bump MSRV to 1.75.0 #8205

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
fitzgen merged 2 commits into from
Mar 21, 2024
Merged

Bump MSRV to 1.75.0 #8205

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
92f5a6b
Bump MSRV to 1.75.0
alexcrichton Mar 21, 2024
e04342b
Fix dead code warning in onnx
alexcrichton Mar 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -140,7 +140,7 @@ authors = ["The Wasmtime Project Developers"]
edition = "2021"
# Wasmtime's current policy is that this number can be no larger than the
# current stable release of Rust minus 2.
rust-version = "1.74.0"
rust-version = "1.75.0"

[workspace.lints.rust]
# Turn on some lints which are otherwise allow-by-default in rustc.
Expand Down
2 changes: 1 addition & 1 deletion crates/wasi-nn/src/backend/onnxruntime.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ impl BackendFromDir for OnnxBackend {
}
}

struct ONNXGraph(Arc<Mutex<Session>>, ExecutionTarget);
struct ONNXGraph(Arc<Mutex<Session>>, #[allow(dead_code)] ExecutionTarget);
Copy link
Copy Markdown
Member Author

@alexcrichton alexcrichton Mar 21, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc @devigned I had to add this as it's a new warning in rustc, and I'm not sure if this indicates a bug where this should have been used or if it should be removed.

Copy link
Copy Markdown
Contributor

@devigned devigned Mar 21, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the heads up. I'll take a look.


unsafe impl Send for ONNXGraph {}
unsafe impl Sync for ONNXGraph {}
Expand Down