Skip to content

build: make the c-api CMakeLists.txt easier to import#8490

Merged
alexcrichton merged 1 commit into
bytecodealliance:mainfrom
dundargoc:c-api/cmake
Apr 26, 2024
Merged

build: make the c-api CMakeLists.txt easier to import#8490
alexcrichton merged 1 commit into
bytecodealliance:mainfrom
dundargoc:c-api/cmake

Conversation

@dundargoc
Copy link
Copy Markdown
Contributor

Currently the CMakeLists.txt is designed to only be consumed by a parent project, which limits its flexibility. Adding a project() function allows it to also be built as its own project.

Also set USES_TERMINAL_BUILD to TRUE in ExternalProject_Add(), which allows getting the installation progress output from cargo build.

Currently the CMakeLists.txt is designed to only be consumed by a parent
project, which limits its flexibility. Adding a `project()` function
allows it to also be built as its own project.

Also set `USES_TERMINAL_BUILD` to `TRUE` in `ExternalProject_Add()`,
which allows getting the installation progress output from `cargo
build`.
@dundargoc dundargoc requested a review from a team as a code owner April 26, 2024 11:03
@dundargoc dundargoc requested review from fitzgen and removed request for a team April 26, 2024 11:03
Copy link
Copy Markdown
Member

@alexcrichton alexcrichton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@alexcrichton alexcrichton added this pull request to the merge queue Apr 26, 2024
Merged via the queue into bytecodealliance:main with commit 356710d Apr 26, 2024
@dundargoc dundargoc deleted the c-api/cmake branch April 26, 2024 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants