egraphs: Const propagate bitwise float operations#8625
Merged
Conversation
alexcrichton
approved these changes
May 15, 2024
fitzgen
approved these changes
May 15, 2024
Comment on lines
+299
to
+310
| (decl pure f32_neg (Ieee32) Ieee32) | ||
| (extern constructor f32_neg f32_neg) | ||
| (decl pure f32_abs (Ieee32) Ieee32) | ||
| (extern constructor f32_abs f32_abs) | ||
| (decl pure f32_copysign (Ieee32 Ieee32) Ieee32) | ||
| (extern constructor f32_copysign f32_copysign) | ||
| (decl pure f64_neg (Ieee64) Ieee64) | ||
| (extern constructor f64_neg f64_neg) | ||
| (decl pure f64_abs (Ieee64) Ieee64) | ||
| (extern constructor f64_abs f64_abs) | ||
| (decl pure f64_copysign (Ieee64 Ieee64) Ieee64) | ||
| (extern constructor f64_copysign f64_copysign) |
Member
There was a problem hiding this comment.
Can we move these to prelude.isle?
github-actions
Bot
added
cranelift
Subscribe to Label ActionDetailsThis issue or pull request has been labeled: "cranelift", "isle"Thus the following users have been cc'd because of the following labels:
To subscribe or unsubscribe from this label, edit the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
👋 Hey,
This PR adds constant propagation for the few bitwise floating point operations that we have (
fneg/fabs/fcopysign). Since these operations are guaranteed to be done in a bitwise manner it should be safe to constant propagate them.