Use [su]extend_maybe in the iconst_[su] extractors#8686
Merged
Conversation
This enables various things -- like `x * 2` → `x + x` -- for 128-bit numbers as well.
jameysharp
approved these changes
May 23, 2024
Contributor
jameysharp
left a comment
jameysharp
left a comment
There was a problem hiding this comment.
Very nice, thank you!
alexcrichton
added a commit
to alexcrichton/wasmtime
that referenced
this pull request
May 29, 2024
…odealliance#8686)" This reverts commit 66f499f.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This enables various things -- like
x * 2→x + xandx * -1→-x-- for 128-bit numbers as well.Thanks to @jameysharp over in #8653 (comment) for noticing that these extractors weren't ever going to match 128-bit numbers as-written, even though the rules could produce 128-bit values.