Skip to content

Explorer with clif fix: cache does not emit clif files#9027

Merged
elliottt merged 1 commit into
bytecodealliance:mainfrom
vulc41n:explorer-clif-fix
Jul 27, 2024
Merged

Explorer with clif fix: cache does not emit clif files#9027
elliottt merged 1 commit into
bytecodealliance:mainfrom
vulc41n:explorer-clif-fix

Conversation

@vulc41n
Copy link
Copy Markdown
Contributor

@vulc41n vulc41n commented Jul 26, 2024

Hey 👋

I found a bug introduced in PR#8972. When cache is used, no clif files can be emited. I propose to disable the cache when exploring with cranelift

@fitzgen

@vulc41n vulc41n requested a review from a team as a code owner July 26, 2024 21:43
@vulc41n vulc41n requested review from elliottt and removed request for a team July 26, 2024 21:43
Copy link
Copy Markdown
Member

@elliottt elliottt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice find!

@elliottt elliottt added this pull request to the merge queue Jul 26, 2024
Merged via the queue into bytecodealliance:main with commit 3767f76 Jul 27, 2024
@vulc41n vulc41n deleted the explorer-clif-fix branch August 7, 2024 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants