Bump tokio version to 1.30 to avoid duplicate socket2 dependency#9043
Merged
Conversation
alexcrichton
approved these changes
Jul 30, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In #8983, we introduced the
redisdependency, which relies onsocket20.5. This conflicts with our existing version 0.4, leading tocargo denythrowing the following error when trying to merge #9032 (https://github.com/bytecodealliance/wasmtime/actions/runs/10147488558/job/28058006599).Therefore, this patch updates the version of
tokiofrom 1.29.1 to 1.30. With this update, we will no longer have duplicate socket2 dependencies, as both will depend on version 0.5.NOTE: I could also downgrade the
redisversion to 0.25.0, which relies on socket2 0.4, but this version has significant bugs and has been yanked.