Skip to content

Disable the trace-log feature of regalloc2 by default#9128

Merged
cfallin merged 1 commit into
bytecodealliance:mainfrom
bjorn3:disable_regalloc2_trace_log
Aug 14, 2024
Merged

Disable the trace-log feature of regalloc2 by default#9128
cfallin merged 1 commit into
bytecodealliance:mainfrom
bjorn3:disable_regalloc2_trace_log

Conversation

@bjorn3
Copy link
Copy Markdown
Contributor

@bjorn3 bjorn3 commented Aug 14, 2024

This makes register allocation a bit faster when these logs are not used.

@bjorn3 bjorn3 requested a review from a team as a code owner August 14, 2024 15:23
@bjorn3 bjorn3 requested review from abrown and removed request for a team August 14, 2024 15:23
Copy link
Copy Markdown
Member

@cfallin cfallin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like this was (probably accidentally) added as part of #8196 and has been on since March (cc @fitzgen, though I've made the same mistake in PRs before too; this one just slipped through I guess). Thanks for finding it!

@cfallin cfallin enabled auto-merge August 14, 2024 15:27
@cfallin cfallin added this pull request to the merge queue Aug 14, 2024
@Amanieu
Copy link
Copy Markdown
Contributor

Amanieu commented Aug 14, 2024

The trace-log feature on cranelift-codegen is also unconditionally enabled in the root Cargo.toml for wasmtime-cli.

This makes register allocation a bit faster when these logs are not
used.
auto-merge was automatically disabled August 14, 2024 15:46

Head branch was pushed to by a user without write access

@bjorn3 bjorn3 force-pushed the disable_regalloc2_trace_log branch from 62e96c9 to fd0fb48 Compare August 14, 2024 15:46
@bjorn3 bjorn3 requested a review from a team as a code owner August 14, 2024 15:46
@bjorn3
Copy link
Copy Markdown
Contributor Author

bjorn3 commented Aug 14, 2024

Fixed.

@cfallin cfallin removed this pull request from the merge queue due to a manual request Aug 14, 2024
Copy link
Copy Markdown
Member

@cfallin cfallin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Amanieu for catching the top-level change as well!

@cfallin cfallin added this pull request to the merge queue Aug 14, 2024
Merged via the queue into bytecodealliance:main with commit 3db94f5 Aug 14, 2024
@bjorn3 bjorn3 deleted the disable_regalloc2_trace_log branch August 14, 2024 16:39
@fitzgen
Copy link
Copy Markdown
Member

fitzgen commented Aug 14, 2024

Whoops yeah the intention was to enable it by default for clif-util but not for everything all the time!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants