Remove Scheme booleans#9522
Merged
cfallin merged 1 commit intoOct 30, 2024
Merged
Conversation
Kmeakin
force-pushed
the
km/isle/remove-scheme-booleans
branch
from
69364fd to
f3933a0
Compare
cfallin
approved these changes
Oct 30, 2024
Member
cfallin
left a comment
cfallin
left a comment
There was a problem hiding this comment.
LGTM for the change in the title; would you mind rebasing out the langref stuff from the other PR? Once that's separated, I'm happy to land this!
Kmeakin
force-pushed
the
km/isle/remove-scheme-booleans
branch
from
0e0430f to
f3933a0
Compare
Contributor
Author
Thanks, I must have messed up the rebase somehow. GitHub PRs are more confusing compared to Gerrit IMO |
Kmeakin
force-pushed
the
km/isle/remove-scheme-booleans
branch
2 times, most recently
from
62396a6 to
9354420
Compare
The `#t` and `#f` syntax is misleading: they are actually integer expressions, not booleans, so `#t` represents the integer `1` but *not* the boolean `true`. They have been replaced by the named constants `$true` and `$false`, and not used anywhere except tests, so they can be removed without breaking any lowering/optimization code. Copyright (c) 2024, Arm Limited. Signed-off-by: Karl Meakin <karl.meakin@arm.com>
Kmeakin
force-pushed
the
km/isle/remove-scheme-booleans
branch
from
9354420 to
96881d6
Compare
cfallin
approved these changes
Oct 30, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
#tand#fsyntax is misleading: they are actually expressions, not booleans, so#trepresents the integer1but not the booleantrue. They have been replaced by the named constants$trueand$false, and not used anywhere except tests, so they can be removed without breaking any lowering/optimization code.