ISLE: Add block comments#9529
Merged
Merged
Conversation
Kmeakin
force-pushed
the
km/isle/block-comments
branch
2 times, most recently
from
3e3dbfa to
4441282
Compare
cfallin
approved these changes
Oct 31, 2024
Kmeakin
force-pushed
the
km/isle/block-comments
branch
from
4441282 to
2e3f149
Compare
Closes bytecodealliance#3542 Copyright (c) 2024, Arm Limited. Signed-off-by: Karl Meakin <karl.meakin@arm.com>
Copyright (c) 2024, Arm Limited. Signed-off-by: Karl Meakin <karl.meakin@arm.com>
The ISLE language is superficially similar to WebAssembly, so to reduce confusion I think it would help to copy the wasm spec where possible. This is technically a breaking change, since `\x0C` (`\f`) will no longer be lexed as whitespace, but this character is exceedingly rare in practice. Copyright (c) 2024, Arm Limited. Signed-off-by: Karl Meakin <karl.meakin@arm.com>
Kmeakin
force-pushed
the
km/isle/block-comments
branch
from
2e3f149 to
1c99101
Compare
github-actions
Bot
added
cranelift
Subscribe to Label ActionDetailsThis issue or pull request has been labeled: "cranelift", "cranelift:area:x64", "isle"Thus the following users have been cc'd because of the following labels:
To subscribe or unsubscribe from this label, edit the |
cfallin
approved these changes
Oct 31, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Solves #3542.
Also adjusts the lexical syntax to be closer to wasm while I was at it: "\r" can be used to terminate a line-comment, and "\f" is no longer considered whitespace, but no-one uses that character anyway.
We could also align the line-comment syntax with wasm (require two semicolons to start a line comment instead of one), but that would IMO create too much churn