Optimize generated code via the CLI by default#973
Merged
alexcrichton merged 3 commits intoFeb 24, 2020
Conversation
This commit updates the behavior of the CLI and adds a new flag. It first enables the `--optimize` flag by default, ensuring that usage of the `wasmtime` CLI will enable cranelift optimizations by default. Next it also adds a `--opt-level` flag which is similar to Rust's `-Copt-level` where it takes a string argument of how to optimize. This is updates to support 0/1/2/s, where 1 is currently the same as 2 but added for consistency with other compilers. The default setting is `--opt-level=2`. When the `-O` flag is not passed the `--opt-level` flag is used, otherwise `-O` takes precedent in the sense that it implies `--opt-level=2` which is the highest optimization level. The thinking is that these flags will in general select the highest optimization level specified as the final optimization level.
fitzgen
approved these changes
Feb 24, 2020
peterhuene
reviewed
Feb 24, 2020
peterhuene
reviewed
Feb 24, 2020
peterhuene
approved these changes
Feb 24, 2020
Member
peterhuene
left a comment
peterhuene
left a comment
There was a problem hiding this comment.
Just the above comment regarding the help text.
Member
|
Looks like a test needs updating given the new signature for |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit updates the behavior of the CLI and adds a new flag. It
first enables the
--optimizeflag by default, ensuring that usage ofthe
wasmtimeCLI will enable cranelift optimizations by default. Nextit also adds a
--opt-levelflag which is similar to Rust's-Copt-levelwhere it takes a string argument of how to optimize. Thisis updates to support 0/1/2/s, where 1 is currently the same as 2 but
added for consistency with other compilers. The default setting is
--opt-level=2.When the
-Oflag is not passed the--opt-levelflag is used,otherwise
-Otakes precedent in the sense that it implies--opt-level=2which is the highest optimization level. The thinking isthat these flags will in general select the highest optimization level
specified as the final optimization level.