winch Aarch64: signed_convert and unsigned_convert#9787
Merged
saulecabrera merged 2 commits intoDec 11, 2024
Conversation
minirop
requested review from
alexcrichton and
cfallin
and removed request for
a team
Member
saulecabrera
left a comment
saulecabrera
left a comment
There was a problem hiding this comment.
Looks good to me, a few typos below.
saulecabrera
approved these changes
Dec 11, 2024
Member
saulecabrera
left a comment
saulecabrera
left a comment
There was a problem hiding this comment.
Oh my bad, I reviewed commit by commit and realized that in your second commit the documentation is fixed. Thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implement the following MASM instructions for the Aarch64 platform (#8321):
And fix mistakes introduced by #9767.