Skip to content

pulley: Disable the WebAssembly threads proposal #9818

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alexcrichton merged 1 commit into from
Dec 14, 2024
Merged

pulley: Disable the WebAssembly threads proposal #9818

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 8 additions & 5 deletions crates/wasmtime/src/config.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1960,12 +1960,15 @@ impl Config {
#[cfg(any(feature = "cranelift", feature = "winch"))]
match self.compiler_config.strategy {
None | Some(Strategy::Cranelift) => {
// Pulley is just starting and most errors are because of
// unsupported lowerings which is a first-class error. Some
// errors are panics though due to unimplemented bits in ABI
// code and those causes are listed here.
// Pulley at this time fundamentally doesn't support the
// `threads` proposal, notably shared memory, because Rust can't
// safely implement loads/stores in the face of shared memory.
//
// Additionally pulley currently panics on tail-call generation
// in Cranelift ABI call which will get implemented in the
// future but is listed here for now as unsupported.
if self.compiler_target().is_pulley() {
return WasmFeatures::TAIL_CALL;
return WasmFeatures::TAIL_CALL | WasmFeatures::THREADS;
}

// Other Cranelift backends are either 100% missing or complete
Expand Down
14 changes: 6 additions & 8 deletions crates/wast-util/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -298,6 +298,12 @@ impl Compiler {
}

Compiler::CraneliftPulley => {
// Pulley at this time fundamentally does not support threads
// due to being unable to implement non-atomic loads/stores
// safely.
if config.threads() {
return true;
}
// Unsupported proposals. Note that other proposals have partial
// support at this time (pulley is a work-in-progress) and so
// individual tests are listed below as "should fail" even if
Expand Down Expand Up @@ -397,9 +403,7 @@ impl WastTest {
let unsupported = [
"misc_testsuite/int-to-float-splat.wast",
"misc_testsuite/issue6562.wast",
"misc_testsuite/memory-combos.wast",
"misc_testsuite/memory64/simd.wast",
"misc_testsuite/memory64/threads.wast",
"misc_testsuite/simd/almost-extmul.wast",
"misc_testsuite/simd/canonicalize-nan.wast",
"misc_testsuite/simd/cvt-from-uint.wast",
Expand All @@ -413,11 +417,6 @@ impl WastTest {
"misc_testsuite/simd/spillslot-size-fuzzbug.wast",
"misc_testsuite/simd/unaligned-load.wast",
"misc_testsuite/simd/v128-select.wast",
"misc_testsuite/threads/LB_atomic.wast",
"misc_testsuite/threads/MP_atomic.wast",
"misc_testsuite/threads/MP_wait.wast",
"misc_testsuite/threads/SB_atomic.wast",
"misc_testsuite/threads/load-store-alignment.wast",
"misc_testsuite/winch/_simd_address.wast",
"misc_testsuite/winch/_simd_const.wast",
"misc_testsuite/winch/_simd_load.wast",
Expand All @@ -432,7 +431,6 @@ impl WastTest {
"spec_testsuite/proposals/relaxed-simd/relaxed_laneselect.wast",
"spec_testsuite/proposals/relaxed-simd/relaxed_madd_nmadd.wast",
"spec_testsuite/proposals/relaxed-simd/relaxed_min_max.wast",
"spec_testsuite/proposals/threads/atomic.wast",
"spec_testsuite/simd_address.wast",
"spec_testsuite/simd_align.wast",
"spec_testsuite/simd_bit_shift.wast",
Expand Down