Skip to content

[DWARF] Make the GC of child tags conservative by default#9829

Merged
fitzgen merged 2 commits into
bytecodealliance:mainfrom
SingleAccretion:DI-Gc
Dec 16, 2024
Merged

[DWARF] Make the GC of child tags conservative by default#9829
fitzgen merged 2 commits into
bytecodealliance:mainfrom
SingleAccretion:DI-Gc

Conversation

@SingleAccretion
Copy link
Copy Markdown
Contributor

Only allow for GCing of a known set of 'standalone' or 'structural' DIEs.

This is still likely not fully correct, but at least it is more correct than what was there before.

Fixes #9828.

@SingleAccretion SingleAccretion marked this pull request as ready for review December 15, 2024 23:09
@SingleAccretion SingleAccretion requested a review from a team as a code owner December 15, 2024 23:09
@SingleAccretion SingleAccretion requested review from dicej and removed request for a team December 15, 2024 23:09
Make the conservatively correct choice the default one.
Copy link
Copy Markdown
Member

@fitzgen fitzgen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense, thanks!

@fitzgen fitzgen added this pull request to the merge queue Dec 16, 2024
Merged via the queue into bytecodealliance:main with commit e4abe55 Dec 16, 2024
@SingleAccretion SingleAccretion deleted the DI-Gc branch December 16, 2024 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[DWARF] Inheritance DW_TAGs dropped by GC

2 participants