Skip to content

pulley: Assert calling-conventions match instructions #9836

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
alexcrichton wants to merge 1 commit into from
Closed

pulley: Assert calling-conventions match instructions #9836

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 18 additions & 9 deletions cranelift/codegen/src/isa/pulley_shared/abi.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -491,21 +491,30 @@ where
match dest {
// "near" calls are pulley->pulley calls so they use a normal "call"
// opcode
CallDest::ExtName(name, RelocDistance::Near) => smallvec![Inst::Call {
info: Box::new(info.map(|()| name.clone()))
CallDest::ExtName(name, RelocDistance::Near) => {
assert_eq!(info.callee_conv, isa::CallConv::Tail);
smallvec![Inst::Call {
info: Box::new(info.map(|()| name.clone()))
}
.into()]
}
.into()],
// "far" calls are pulley->host calls so they use a different opcode
// which is lowered with a special relocation in the backend.
CallDest::ExtName(name, RelocDistance::Far) => smallvec![Inst::IndirectCallHost {
info: Box::new(info.map(|()| name.clone()))
CallDest::ExtName(name, RelocDistance::Far) => {
assert_eq!(info.callee_conv, isa::CallConv::SystemV);
smallvec![Inst::IndirectCallHost {
info: Box::new(info.map(|()| name.clone()))
}
.into()]
}
.into()],
// Indirect calls are all assumed to be pulley->pulley calls
CallDest::Reg(reg) => smallvec![Inst::IndirectCall {
info: Box::new(info.map(|()| XReg::new(*reg).unwrap()))
CallDest::Reg(reg) => {
assert_eq!(info.callee_conv, isa::CallConv::Tail);
smallvec![Inst::IndirectCall {
info: Box::new(info.map(|()| XReg::new(*reg).unwrap()))
}
.into()]
}
.into()],
}
}

Expand Down