Winch: Add SIMD load and extend and load and splat instructions for x64#9950
Merged
saulecabrera merged 11 commits intoJan 13, 2025
Merged
Conversation
jeffcharles
requested review from
abrown and
pchickey
and removed request for
a team
Member
|
I can take this review. |
Subscribe to Label ActionDetailsThis issue or pull request has been labeled: "winch"Thus the following users have been cc'd because of the following labels:
To subscribe or unsubscribe from this label, edit the |
saulecabrera
reviewed
Jan 9, 2025
Member
saulecabrera
left a comment
saulecabrera
left a comment
There was a problem hiding this comment.
Looking good! Left some comments inline.
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue Bot
pushed a commit
that referenced
this pull request
Jan 12, 2025
…64 (#9950) * Winch: Add SIMD load and extend and load and splat instructions * Try removing simd_align from the unsupported for Winch list * No more todos and rename loadkind variant * Use AVX instructions for loads * Adjust load with splat instructions to use AVX * SIMD spec tests for Winch should fail on x64 MacOS * Refine check for should-fail * Adjust conditional check to avoid compile error
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #8093. Adds support on x64 with AVX2 for:
v128.load8x8_sv128.load8x8_uv128.load16x4_sv128.load16x4_uv128.load32x2_sv128.load32x2_uv128.load8_splatv128.load16_splatv128.load32_splatv128.load64_splatI've changed
wasm_loadon the macroassemblers to take aLoadKindinstead ofOption<ExtendKind>to model the additional vector operations (vector extends and splats), but I'm open to changing that to a different abstraction.