fix: improve null safety and logging in main.ts#1811
Open
hobostay wants to merge 1 commit intobytedance:mainfrom
Open
fix: improve null safety and logging in main.ts#1811hobostay wants to merge 1 commit intobytedance:mainfrom
hobostay wants to merge 1 commit intobytedance:mainfrom
Conversation
- Fix potential null reference crash when primarySource is undefined in setDisplayMediaRequestHandler - Replace console.log with logger.error for consistent error logging - Remove duplicate window-all-closed event handler registration Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
✅ Deploy Preview for agent-tars-docs canceled.
|
✅ Deploy Preview for tarko canceled.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes three issues in
apps/ui-tars/src/main/main.ts:Fix potential null reference crash - Added null check for
primarySourceinsetDisplayMediaRequestHandler. Previously used non-null assertion operator!which could cause runtime error when no matching source is found.Improve error logging consistency - Changed
console.logtologger.errorin the.catch()handler for consistency with the project's logging pattern.Remove duplicate event handler - Removed duplicate
window-all-closedevent listener registration (registered at both lines 119-124 and 209-214).Changes
primarySourcewith fallback to first available sourceconsole.logwithlogger.errorfor proper error loggingwindow-all-closedevent handler registrationTest plan
🤖 Generated with Claude Code