WIP: [fix] make getVectorFunction return nullptr instead of throwing exception in case of result type mismatch#248
Open
markjin1990 wants to merge 2 commits intobytedance:mainfrom
Conversation
…tion in case of result type mismatch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: close #247
Type of Change
Description
The function
repeat(VARCHAR, INTEGER)can both be scalar function and return VARCHAR, and be vector function and return ARRAY(VARCHAR). Current compileRewrittenExpression will crash immediately when it first finds a vector function registration forrepeat(VARCHAR, INTEGER)with return typeARRAY(VARCHAR)when the functionrepeatitself is in fact a scalar function in the following SQL.'''
SELECT num,
row_number() OVER (
PARTITION BY
num
ORDER BY
num
) AS idx
FROM (
SELECT 1 AS NUM
UNION
SELECT 2 AS NUM
) LATERAL VIEW explode(split(repeat(',', num -1), ',')) row_repeat
'''
Performance Impact
No Impact: This change does not affect the critical path (e.g., build system, doc, error handling).
Positive Impact: I have run benchmarks.
Click to view Benchmark Results
Negative Impact: Explained below (e.g., trade-off for correctness).
Release Note
Please describe the changes in this PR
Release Note:
Checklist (For Author)
Breaking Changes
No
Yes (Description: ...)
Click to view Breaking Changes