Support other names for envDefault#324
Merged
caarlos0 merged 2 commits intocaarlos0:mainfrom Aug 24, 2024
Merged
Conversation
ccoVeille
approved these changes
Aug 14, 2024
ccoVeille
left a comment
There was a problem hiding this comment.
I like your PR as it could help to keep tag in the struct in our prefered case (snake_case, kebab, … whatever)
ccoVeille
approved these changes
Aug 22, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #324 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 3 3
Lines 499 504 +5
=========================================
+ Hits 499 504 +5 ☔ View full report in Codecov by Sentry. |
Owner
|
thanks! |
BorzdeG
pushed a commit
to BorzdeG/env
that referenced
this pull request
Aug 24, 2024
* Support other names for envDefault * Rename DefaultTagName to DefaultValueTagName
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We can change the "env" to some other tag name using opt.TagName. I think that it will be more consistent to have an opt.DefaultTagName to change the tag for "envDefault".
That could help switching from other env libraries.