Skip to content

Support other names for envDefault#324

Merged
caarlos0 merged 2 commits intocaarlos0:mainfrom
dnovikoff:env_default_name_option
Aug 24, 2024
Merged

Support other names for envDefault#324
caarlos0 merged 2 commits intocaarlos0:mainfrom
dnovikoff:env_default_name_option

Conversation

@dnovikoff
Copy link
Contributor

We can change the "env" to some other tag name using opt.TagName. I think that it will be more consistent to have an opt.DefaultTagName to change the tag for "envDefault".

That could help switching from other env libraries.

Copy link

@ccoVeille ccoVeille left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like your PR as it could help to keep tag in the struct in our prefered case (snake_case, kebab, … whatever)

@dnovikoff dnovikoff requested a review from ccoVeille August 22, 2024 21:28
@codecov
Copy link

codecov bot commented Aug 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (aa50469) to head (a3b3e46).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #324   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            3         3           
  Lines          499       504    +5     
=========================================
+ Hits           499       504    +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@caarlos0 caarlos0 merged commit 17fdb91 into caarlos0:main Aug 24, 2024
@caarlos0
Copy link
Owner

thanks!

BorzdeG pushed a commit to BorzdeG/env that referenced this pull request Aug 24, 2024
* Support other names for envDefault

* Rename DefaultTagName to DefaultValueTagName
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants